From 3fa01a63d8b427c2e84c37753b9ed6ed254c46ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sigrid=20Solveig=20Hafl=C3=ADnud=C3=B3ttir?= Date: Wed, 14 Feb 2024 16:28:50 +0000 Subject: [PATCH] screen: fix an UB --- src/devices/screen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/devices/screen.c b/src/devices/screen.c index 13e3aaa..a6ebee0 100644 --- a/src/devices/screen.c +++ b/src/devices/screen.c @@ -62,8 +62,8 @@ screen_2bpp(Uint8 *layer, Uint8 *addr, Uint16 x1, Uint16 y1, Uint16 color, int f int w = uxn_screen.width, h = uxn_screen.height, opaque = blending[4][color]; Uint16 y, ymod = (fy < 0 ? 7 : 0), ymax = y1 + ymod + fy * 8; Uint16 x, xmod = (fx > 0 ? 7 : 0), xmax = x1 + xmod - fx * 8; - for(y = y1 + ymod; y != ymax; y += fy) { - int c = *addr++ | (*(addr + 7) << 8), row = y * w; + for(y = y1 + ymod; y != ymax; y += fy, addr++) { + int c = addr[0] | (addr[8] << 8), row = y * w; if(y < h) for(x = x1 + xmod; x != xmax; x -= fx, c >>= 1) { Uint8 ch = (c & 1) | ((c >> 7) & 2);