d6
/
xz-analysis-mirror
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix SHA-256 authors. 

The initial commit 5d018dc035
in 2007 had a comment in sha256.c that the code is based on
Crypto++ Library 5.5.1. In 2009 the Authors list in sha256.c
and the AUTHORS file was updated with information that the
code had come from Crypto++ but via 7-Zip. I know I had viewed
7-Zip's SHA-256 code but back then the C code has been identical
enough with Crypto++, so I don't why I thought the author info
would need that extra step via 7-Zip for this single file.

Another error is that I had mixed sha.* and shacal2.* files
when checking for author info in Crypto++. The shacal2.* files
aren't related to liblzma's sha256.c and thus Kevin Springle's
code in Crypto++ isn't either.
This commit is contained in:
Lasse Collin 2024-02-09 17:20:31 +02:00
parent 21d9cbae9e
commit 76946dc433
2 changed files with 6 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
AUTHORS
View File

@ -9,10 +9,8 @@ Authors of XZ Utils
specifically the LZMA SDK <https://7-zip.org/sdk.html>. Without specifically the LZMA SDK <https://7-zip.org/sdk.html>. Without
this code, XZ Utils wouldn't exist. this code, XZ Utils wouldn't exist.
The SHA-256 implementation in liblzma is based on the code found from The SHA-256 implementation in liblzma is based on code written by
7-Zip <https://7-zip.org/>, which has a modified version of the SHA-256 Wei Dai in Crypto++ Library <https://www.cryptopp.com/>.
code found from Crypto++ <https://www.cryptopp.com/>. The SHA-256 code
in Crypto++ was written by Kevin Springle and Wei Dai.
Some scripts have been adapted from gzip. The original versions Some scripts have been adapted from gzip. The original versions
were written by Jean-loup Gailly, Charles Levert, and Paul Eggert. were written by Jean-loup Gailly, Charles Levert, and Paul Eggert.

14
src/liblzma/check/sha256.c
View File

@ -2,18 +2,12 @@
// //
/// \file sha256.c /// \file sha256.c
/// \brief SHA-256 /// \brief SHA-256
///
/// \todo Crypto++ has x86 ASM optimizations. They use SSE so if they
/// are imported to liblzma, SSE instructions need to be used
/// conditionally to keep the code working on older boxes.
// //
// This code is based on the code found from 7-Zip, which has a modified // The C code is based on the public domain SHA-256 code found from
// version of the SHA-256 found from Crypto++ <https://www.cryptopp.com/>. // Crypto++ Library 5.5.1 released in 2007: https://www.cryptopp.com/
// The code was modified a little to fit into liblzma. // A few minor tweaks have been made in liblzma.
// //
// Authors: Kevin Springle // Authors: Wei Dai
// Wei Dai
// Igor Pavlov
// Lasse Collin // Lasse Collin
// //
// This file has been put into the public domain. // This file has been put into the public domain.